merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r166792127
########## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.java ########## @@ -0,0 +1,322 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.authorization; + +import static java.util.concurrent.TimeUnit.SECONDS; +import static org.apache.pulsar.zookeeper.ZooKeeperCache.cacheTimeOutInSec; + +import java.util.Map; +import java.util.Map.Entry; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.atomic.AtomicInteger; + +import javax.servlet.http.HttpServletRequest; + +import org.apache.commons.lang3.StringUtils; +import org.apache.pulsar.broker.PulsarServerException; +import org.apache.pulsar.broker.ServiceConfiguration; +import org.apache.pulsar.broker.cache.ConfigurationCacheService; +import org.apache.pulsar.common.naming.DestinationName; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.collect.Maps; + +/** + * Authorization service that manages plugable authorization provider and authorize requests accordingly. + * + */ +public class AuthorizationService { + private static final Logger log = LoggerFactory.getLogger(AuthorizationService.class); + + private final Map<String, AuthorizationProvider> providers = Maps.newHashMap(); + private final ServiceConfiguration conf; + public static final String AUTHORIZATION_METHOD_HEADER_NAME = "authrorization.method"; + + public AuthorizationService(ServiceConfiguration conf, ConfigurationCacheService configCache) + throws PulsarServerException { + + this.conf = conf; + if (this.conf.isAuthorizationEnabled()) { + try { + AuthorizationProvider provider; + for (String className : conf.getAuthorizationProviders()) { + if (className.isEmpty()) { + continue; + } + provider = (AuthorizationProvider) Class.forName(className).newInstance(); + provider.initialize(conf, configCache); + providers.put(provider.getAuthorizationMethodName(), provider); + log.info("{} has been loaded.", className); + } + if (providers.isEmpty()) { + log.warn("No authorization providers are loaded."); + } + } catch (Throwable e) { + throw new PulsarServerException("Failed to load an authorization provider.", e); + } + } else { + log.info("Authorization is disabled"); + } + + } + + /** + * Check if the specified role has permission to send messages to the specified fully qualified destination name. + * + * @param destination + * the fully qualified destination name associated with the destination. + * @param role + * the app id used to send messages to the destination. + * @param authMethod + * authorization method name using which request should be authorized <br/> + * if authMethod is null then : it checks authorization from all the available providers. + */ + public CompletableFuture<Boolean> canProduceAsync(DestinationName destination, String role, String authMethodName) { + + if (!this.conf.isAuthorizationEnabled()) { + return CompletableFuture.completedFuture(true); + } + + // check all providers if authMethodName is not present + if (authMethodName == null) { + return canProduceAsync(destination, role); + } + + AuthorizationProvider provider = providers.get(authMethodName); + if (provider != null) { + return provider.canProduceAsync(destination, role); + } + CompletableFuture<Boolean> result = new CompletableFuture<>(); Review comment: We have a `FutureUtil.failedFuture(...)` utility ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
