zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167251458
########## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java ########## @@ -359,4 +362,59 @@ public EncryptionKeyInfo getPrivateKey(String keyName, Map<String, String> keyMe reader.close(); log.info("-- Exiting {} test --", methodName); } + + + @Test + public void testSimpleReaderReachEndofTopic() throws Exception { Review comment: thanks, will add the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services