merlimat commented on a change in pull request #1208: Add hostname-verification 
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167302503
 
 

 ##########
 File path: pulsar-client/pom.xml
 ##########
 @@ -74,6 +74,17 @@
       <groupId>com.google.code.gson</groupId>
       <artifactId>gson</artifactId>
     </dependency>
+    
+    <dependency>
+      <groupId>org.apache.httpcomponents</groupId>
 
 Review comment:
   This should be added to the client shading as well. Also in all the other 
shading config they need to reuse the same list of the client shading conf.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to