rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167318158
##########
File path: pom.xml
##########
@@ -138,6 +138,18 @@ flexible messaging model and an intuitive client
API.</description>
</exclusions>
</dependency>
+ <dependency>
Review comment:
I have added `org.apache.httpcomponents:httpclient` in client-shadeed pom
and License file. However, I excluded all other jars from httpclient to avoid
bringing lot of other things from it, but it requires
`commons-logging:commons-logging` for internal logging without it we see
ClassNotFoundException for logger class. So, I have added that dep explicitly
and added to LICENSE and cliend-sahde as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
