ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide 
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167517269
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedConsumerImpl.java
 ##########
 @@ -468,17 +468,20 @@ public void redeliverUnacknowledgedMessages() {
     }
 
     @Override
-    public void redeliverUnacknowledgedMessages(Set<MessageIdImpl> messageIds) 
{
+    public void redeliverUnacknowledgedMessages(Set<MessageId> messageIds) {
 
 Review comment:
   In Consumer.java it doesn't know about the MessageIds. The call takes no 
parameters.
   
   TopicsMessageIdImpl should be a specialization of MessageIdImpl (I assumed 
it was when I originally commented, until i saw Matteo's comment to the same 
effect). If it is a specialization of TopicsMessageIdImpl, then this signature 
doesn't need to change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to