zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide 
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167879404
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PartitionedConsumerImpl.java
 ##########
 @@ -468,17 +468,20 @@ public void redeliverUnacknowledgedMessages() {
     }
 
     @Override
-    public void redeliverUnacknowledgedMessages(Set<MessageIdImpl> messageIds) 
{
+    public void redeliverUnacknowledgedMessages(Set<MessageId> messageIds) {
 
 Review comment:
   Oh, it is in ConsumerBase.java, sorry for the wrong reference of 
Consumer.java. 
   TopicsMessageIdImpl is more need to be a wrapper for MessageIdImpl, and as 
the reply below, may be better to implements MessageId, instead of extends 
MessageIdImpl.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to