sijie commented on a change in pull request #1156: Introduce 
ActiveConsumerListener for realizing if a consumer is active in a failover 
subscription group
URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167909684
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
 ##########
 @@ -241,6 +242,13 @@ public Consumer subscribe(String topic, String 
subscription, ConsumerConfigurati
                     new 
PulsarClientException.InvalidConfigurationException("Consumer configuration 
undefined"));
         }
 
+        if (conf.getActiveConsumerListener() != null
 
 Review comment:
   I think the main motivation for this change here is for supporting failover 
subscription. I would disable this feature for other subscriptions for now, and 
introduce it if we really need it. does that make sense to you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to