ivankelly commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168230410
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -22,6 +22,20 @@ package pulsar.proto;
 option java_package = "org.apache.pulsar.common.api.proto";
 option optimize_for = LITE_RUNTIME;
 
+message Schema {
+       required string name = 1;
+       required bytes version = 2;
+       required bytes schema_data = 3;
 
 Review comment:
   Does the schema data itself have a schema? If we're supporting json, arvo, 
pb, etc, shouldn't we have a separate field to give the reader a hint of how 
they need to parse the schema?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to