merlimat commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168274469
 
 

 ##########
 File path: pulsar-common/src/main/proto/PulsarApi.proto
 ##########
 @@ -22,6 +22,20 @@ package pulsar.proto;
 option java_package = "org.apache.pulsar.common.api.proto";
 option optimize_for = LITE_RUNTIME;
 
+message Schema {
+       required string name = 1;
+       required bytes version = 2;
+       required bytes schema_data = 3;
 
 Review comment:
   I agree that storing the schema data is agnostic to the format, however 
these protobufs are relative to the interactions between client and broker. 
   
   In this case, the producer might use something like 
`Schema.avroOf(MyClass.class)` or `Schema.jsonOf(MyClass.class)`. In this case, 
 don't we need to communicate to the server what kind of schema the client is 
using?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to