maskit commented on a change in pull request #1241: Add REST api to check
host-status for adding/removing from vip
URL: https://github.com/apache/incubator-pulsar/pull/1241#discussion_r168917344
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyServiceStarter.java
##########
@@ -96,28 +97,30 @@ public ProxyServiceStarter(String[] args) throws Exception
{
java.security.Security.addProvider(new
org.bouncycastle.jce.provider.BouncyCastleProvider());
- // create broker service
- ProxyService discoveryService = new ProxyService(config);
+ // create proxy service
+ ProxyService proxyService = new ProxyService(config);
// create a web-service
final WebServer server = new WebServer(config);
Runtime.getRuntime().addShutdownHook(new Thread() {
@Override
public void run() {
try {
- discoveryService.close();
+ proxyService.close();
server.stop();
} catch (Exception e) {
log.warn("server couldn't stop gracefully {}",
e.getMessage(), e);
}
}
});
- discoveryService.start();
+ proxyService.start();
// Setup metrics
DefaultExports.initialize();
server.addServlet("/metrics", new ServletHolder(MetricsServlet.class));
+ server.addRestResources("/admin",
VipStatus.class.getPackage().getName(),
Review comment:
`addRestResources("/", ` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
