rdhabalia commented on a change in pull request #1254: Use advertisedAddress 
for bookies in pulsar standalone
URL: https://github.com/apache/incubator-pulsar/pull/1254#discussion_r169203421
 
 

 ##########
 File path: 
pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/LocalBookkeeperEnsemble.java
 ##########
 @@ -69,17 +69,24 @@ public LocalBookkeeperEnsemble(int numberOfBookies, int 
zkPort, int bkBasePort)
 
     public LocalBookkeeperEnsemble(int numberOfBookies, int zkPort, int 
bkBasePort, String zkDataDirName,
             String bkDataDirName, boolean clearOldData) {
+        this(numberOfBookies, zkPort, bkBasePort, zkDataDirName, 
bkDataDirName, clearOldData, null);
+    }
+
+    public LocalBookkeeperEnsemble(int numberOfBookies, int zkPort, int 
bkBasePort, String zkDataDirName,
+            String bkDataDirName, boolean clearOldData, String 
advertisedAddress) {
         this.numberOfBookies = numberOfBookies;
         this.HOSTPORT = "127.0.0.1:" + zkPort;
         this.ZooKeeperDefaultPort = zkPort;
         this.initialPort = bkBasePort;
         this.zkDataDirName = zkDataDirName;
         this.bkDataDirName = bkDataDirName;
         this.clearOldData = clearOldData;
-        LOG.info("Running " + this.numberOfBookies + " bookie(s).");
+        this.advertisedAddress = null == advertisedAddress ? "127.0.0.1" : 
advertisedAddress;
 
 Review comment:
   should we use 
`ServiceConfigurationUtils.getDefaultOrConfiguredAddress(advertisedAddress)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to