rdhabalia commented on a change in pull request #1276: Refactored 
ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl
URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170383778
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -598,6 +598,13 @@ flexible messaging model and an intuitive client 
API.</description>
       <artifactId>powermock-module-testng</artifactId>
       <scope>test</scope>
     </dependency>
+
+    <dependency>
+      <groupId>org.projectlombok</groupId>
+      <artifactId>lombok</artifactId>
+      <version>1.16.20</version>
+      <scope>provided</scope>
 
 Review comment:
   do we need to include it in `pulsar-client` module? if scope is `provided` 
then does it mean it will not be part of binary distribution generation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to