merlimat commented on a change in pull request #1276: Refactored 
ClientConfuguration to use ClientConfigurationData shared with ClientBuilderImpl
URL: https://github.com/apache/incubator-pulsar/pull/1276#discussion_r170387871
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -598,6 +598,13 @@ flexible messaging model and an intuitive client 
API.</description>
       <artifactId>powermock-module-testng</artifactId>
       <scope>test</scope>
     </dependency>
+
+    <dependency>
+      <groupId>org.projectlombok</groupId>
+      <artifactId>lombok</artifactId>
+      <version>1.16.20</version>
+      <scope>provided</scope>
 
 Review comment:
   Correct, this is marked as `provided` since it's only required at build 
time. No dependency is needed at runtime since the boilerplate code gets 
automatically generated and that's what gets included in the jar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to