merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966347
 
 

 ##########
 File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
 ##########
 @@ -288,6 +288,13 @@ public boolean isGlobal() {
         return cluster == null || 
Constants.GLOBAL_CLUSTER.equalsIgnoreCase(cluster);
     }
 
+    public String getSchemaName() {
+        return getProperty()
+            + "_" + getCluster()
 
 Review comment:
   Since `_` is a valid character for property namespace and such, it will be 
difficult to decode the schema name into a topic name. I would say to stick 
with the current convention of `/` as the divider, unless there is a specific 
reason.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to