merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966891
 
 

 ##########
 File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
 ##########
 @@ -288,6 +288,13 @@ public boolean isGlobal() {
         return cluster == null || 
Constants.GLOBAL_CLUSTER.equalsIgnoreCase(cluster);
     }
 
+    public String getSchemaName() {
+        return getProperty()
+            + "_" + getCluster()
 
 Review comment:
   Cluster has been removed from topic name. Yes, the change is overall still 
in progress, though the main idea is that v2 topic names will never have that. 
   
   Schema shouldn't be supported on v1 topics (or API), but in any case we 
could just do the check, here in `TopicName` class to validate whether cluster 
should be part of the name or not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to