merlimat commented on a change in pull request #1345: Cleanup failed connection
from background thread
URL: https://github.com/apache/incubator-pulsar/pull/1345#discussion_r172425495
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
##########
@@ -105,13 +104,7 @@ void setup() throws Exception {
@Override
@AfterClass(timeOut = 30000)
void shutdown() throws Exception {
- ForkJoinPool.commonPool().execute(() -> {
- try {
- super.shutdown();
- } catch (Exception e) {
- e.printStackTrace();
- }
- });
Review comment:
This is just reverting a previous workaround for the timeouts which was just
moving the problem somewhere else. The shutdown should happen in same thread
and complete in time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
