sijie commented on a change in pull request #1351: Shade 
pulsar-functions-runtime instead of pulsar-functions-worker
URL: https://github.com/apache/incubator-pulsar/pull/1351#discussion_r172705310
 
 

 ##########
 File path: pulsar-broker/pom.xml
 ##########
 @@ -54,6 +54,18 @@
       <artifactId>netty-all</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>${project.groupId}</groupId>
+      <artifactId>pulsar-common</artifactId>
+      <version>${project.version}</version>
+      <exclusions>
 
 Review comment:
   because bookkeeper-server-shaded jar include the circe-checksum when shading 
guava. so circe-checksum is effectively available in pulsar-broker when 
including `bookkeeper-server-shaded` jar. so excluding pulsar-common to make 
the behavior more deterministic. 
   
   that said, we probably don't have to exclude it though. because in the 
classpath we have both shaded guava and non-shaded guava.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to