jai1 commented on a change in pull request #1322: Use private impl for 
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172705462
 
 

 ##########
 File path: pulsar-client-cpp/lib/MessageId.cc
 ##########
 @@ -30,43 +29,51 @@
 
 namespace pulsar {
 
-MessageId::MessageId() : ledgerId_(-1), entryId_(-1), partition_(-1) {}
+class MessageIdImpl {
+   public:
+    MessageIdImpl() : ledgerId_(-1), entryId_(-1), partition_(-1), 
batchIndex_(-1) {}
 
 Review comment:
   Do we need this constructor 
   I though in C++11 we can write 
   
   const int64_t ledgerId_=-1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to