merlimat commented on a change in pull request #1322: Use private impl for 
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172939330
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/MessageId.h
 ##########
 @@ -50,34 +47,44 @@ class MessageId {
     /**
      * Serialize the message id into a binary string for storing
      */
-    virtual void serialize(std::string& result) const;
+    void serialize(std::string& result) const;
 
 Review comment:
   We have `operator<<` though not `operator>>` and these serve a different 
purpose in any case.
   
   Serialize/deserialize are serializing the message id in protobuf format 
(same as `MessageId.serialize()` in Java) and they are used for the Reader so 
that you can store the message id somewhere else and get it later to restart 
the reader on a particular message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to