merlimat closed pull request #1360: Fix race in
PersistentTopicTest#testClosingReplicationProducerTwice
URL: https://github.com/apache/incubator-pulsar/pull/1360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
index 2f0f3506e..d6756b4ba 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
@@ -1205,16 +1205,15 @@ public void testClosingReplicationProducerTwice()
throws Exception {
"http://"; + pulsar.getAdvertisedAddress() + ":" +
pulsar.getConfiguration().getBrokerServicePort());
PulsarClient client =
spy(PulsarClient.builder().serviceUrl(brokerUrl.toString()).build());
PulsarClientImpl clientImpl = (PulsarClientImpl) client;
+ doReturn(new CompletableFuture<Producer>()).when(clientImpl)
+ .createProducerAsync(any(ProducerConfigurationData.class),
any(Schema.class));
ManagedCursor cursor = mock(ManagedCursorImpl.class);
doReturn(remoteCluster).when(cursor).getName();
brokerService.getReplicationClients().put(remoteCluster, client);
PersistentReplicator replicator = new PersistentReplicator(topic,
cursor, localCluster, remoteCluster, brokerService);
- doReturn(new CompletableFuture<Producer>()).when(clientImpl)
- .createProducerAsync(any(ProducerConfigurationData.class));
-
- replicator.startProducer();
+ // PersistentReplicator constructor calls startProducer()
verify(clientImpl)
.createProducerAsync(
any(ProducerConfigurationData.class),
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
