jerrypeng commented on a change in pull request #1373: Functions metrics
prometheus
URL: https://github.com/apache/incubator-pulsar/pull/1373#discussion_r174028725
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
##########
@@ -221,5 +222,22 @@ public void getFunctionStatus(Empty request,
StreamObserver<InstanceCommunicatio
throw new RuntimeException(e);
}
}
+
Review comment:
Sure but I would say lets do it in multiple PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
