sijie commented on a change in pull request #1424: Improve batch message acking
by removing batch message tracker
URL: https://github.com/apache/incubator-pulsar/pull/1424#discussion_r176897753
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -442,38 +382,6 @@ boolean markAckForBatchMessage(BatchMessageIdImpl
batchMessageId, AckType ackTyp
return false;
}
- // if we are consuming a mix of batch and non-batch messages then
cumulative ack on non-batch messages
- // should clean up the ack tracker as well
- private void updateBatchAckTracker(MessageIdImpl message, AckType ackType)
{
- if (batchMessageAckTracker.isEmpty()) {
- return;
- }
- MessageIdImpl lowerKey = batchMessageAckTracker.lowerKey(message);
Review comment:
@merlimat the first PR has a wrong logic on cumulative ack. I fixed it at
ceb7b45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
