ivankelly commented on issue #1415: Recycle OpAddEntry when ledger-ops fails URL: https://github.com/apache/incubator-pulsar/pull/1415#issuecomment-376201587 @rdhabalia @merlimat This change is causing flake in ManagedLedgerBkTest#managedLedgerClosed If you close the ledger, the op is failed and the then recycled. The object may still be references in bookkeeper though, so when the callback triggers, it triggers on a dead object. It'd be much safer to not recycle on error until bookkeeper calls are cancellable.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
