[incubator-pulsar] branch master updated: Revert "Recycle OpAddEntry when ledger-ops fails (#1415)" (#1442)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 358bbc2  Revert "Recycle OpAddEntry when ledger-ops fails (#1415)" 
(#1442)
358bbc2 is described below

commit 358bbc20f151e2fb2f321ab42dce5f68b340bfd3
Author: Ivan Kelly <iv...@apache.org>
AuthorDate: Mon Mar 26 23:06:18 2018 +0200

    Revert "Recycle OpAddEntry when ledger-ops fails (#1415)" (#1442)
    
    If the OpAddEntry is recycled before the callback is triggered, the 
callback is calling into a dead object.
    
    This reverts commit f5ffbbe1ed2b79be1caf4a59688eab006e932ced.
---
 .../src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java     | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
index 701757b..b1f1d56 100644
--- 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
+++ 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java
@@ -99,7 +99,6 @@ class OpAddEntry extends SafeRunnable implements AddCallback, 
CloseCallback {
         if (cb != null) {
             cb.addFailed(e, ctx);
             ml.mbean.recordAddEntryError();
-            this.recycle();
         }
     }
 

-- 
To stop receiving notification emails like this one, please contact
mme...@apache.org.