merlimat commented on a change in pull request #1453: Added Throttling
mechanism to Pulsar Proxy
URL: https://github.com/apache/incubator-pulsar/pull/1453#discussion_r177953311
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -91,18 +93,33 @@ public ProxyConnection(ProxyService proxyService) {
this.state = State.Init;
}
+ @Override
+ public void channelRegistered(ChannelHandlerContext ctx) throws Exception {
+ super.channelRegistered(ctx);
+ activeConnections.inc();
Review comment:
Ok, though still having a counter for rejected connections would grant
visibility on what's happening, with basically no overhead :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services