merlimat commented on a change in pull request #1450: Added multiple position
delete in ManagedLedger
URL: https://github.com/apache/incubator-pulsar/pull/1450#discussion_r178197665
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -1447,8 +1447,17 @@ public void operationFailed(ManagedLedgerException
exception) {
@Override
public void delete(final Position position) throws InterruptedException,
ManagedLedgerException {
- checkNotNull(position);
Review comment:
It would fail anyway the cast: `PositionImpl position = (PositionImpl) pos;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
