merlimat commented on a change in pull request #1465: Used defaults for Netty
allocator used in entry cache
URL: https://github.com/apache/incubator-pulsar/pull/1465#discussion_r178213645
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java
##########
@@ -69,15 +69,14 @@ public String getName() {
return ml.getName();
}
- public final static PooledByteBufAllocator ALLOCATOR = new
PooledByteBufAllocator(
- true, // preferDirect
+ public final static PooledByteBufAllocator ALLOCATOR = new
PooledByteBufAllocator(true, // preferDirect
0, // nHeapArenas,
Review comment:
No, the 0 is intentional, we only use this allocator for entry cache and we
only use direct buffers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
