zhaijack commented on a change in pull request #1365: Delete
PartitionedConsumerImpl, use TopicsConsumerImpl instead
URL: https://github.com/apache/incubator-pulsar/pull/1365#discussion_r178490225
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -384,8 +384,8 @@ public ClientConfigurationData getConfiguration() {
// gets the next single threaded executor from the list of
executors
ExecutorService listenerThread =
externalExecutorProvider.getExecutor();
if (metadata.partitions > 1) {
- consumer = new
PartitionedConsumerImpl<>(PulsarClientImpl.this, conf, metadata.partitions,
listenerThread,
- consumerSubscribedFuture, schema);
+ consumer = new TopicsConsumerImpl<>(PulsarClientImpl.this,
conf,
Review comment:
Thanks, this is similar to what we did in partitioned consumer, mainly by
`getPartitionedTopicMetadata`.
In `TopicsConsumerImpl` we call `subscribeAsync(topic)` for the topic in
conf, and this will call `getPartitionedTopicMetadata` again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
