merlimat closed pull request #1495: Add MultiTopicsConsumerImpl with leaked
commit from partitionedConsumer
URL: https://github.com/apache/incubator-pulsar/pull/1495
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
index 6da72ec08..e7d3b2613 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
@@ -480,6 +480,15 @@ String getHandlerName() {
internalConsumerConfig.setReceiverQueueSize(conf.getReceiverQueueSize());
internalConsumerConfig.setSubscriptionType(conf.getSubscriptionType());
internalConsumerConfig.setConsumerName(consumerName);
+
internalConsumerConfig.setAcknowledgementsGroupTimeMicros(conf.getAcknowledgementsGroupTimeMicros());
+ internalConsumerConfig.setPriorityLevel(conf.getPriorityLevel());
+ internalConsumerConfig.setProperties(conf.getProperties());
+ internalConsumerConfig.setReadCompacted(conf.isReadCompacted());
+
+ if (null != conf.getConsumerEventListener()) {
+
internalConsumerConfig.setConsumerEventListener(conf.getConsumerEventListener());
+ }
+
if (conf.getCryptoKeyReader() != null) {
internalConsumerConfig.setCryptoKeyReader(conf.getCryptoKeyReader());
internalConsumerConfig.setCryptoFailureAction(conf.getCryptoFailureAction());
@@ -758,12 +767,12 @@ private void handleSubscribeOneTopicError(String
topicName, Throwable error, Com
consumers.values().stream().filter(consumer1 -> {
String consumerTopicName = consumer1.getTopic();
if
(TopicName.get(consumerTopicName).getPartitionedTopicName().equals(topicName)) {
+ toCloseNum.incrementAndGet();
return true;
} else {
return false;
}
- }).forEach(consumer2 -> {
- toCloseNum.incrementAndGet();
+ }).collect(Collectors.toList()).forEach(consumer2 -> {
consumer2.closeAsync().whenComplete((r, ex) -> {
consumer2.subscribeFuture().completeExceptionally(error);
allTopicPartitionsNumber.decrementAndGet();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
