merlimat commented on a change in pull request #1520: Pulsar Connect

 File path: 
 @@ -0,0 +1,39 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.connect.twitter;
+public class TwitterFireHoseConfigKeys {
+    public static final String CONSUMER_KEY = "twitter-source.consumerKey";
 Review comment:
   I'm not sure `-` is valid character in a properties file. 
   Since we're starting from scratch though, we could also use yaml to 
configure the source/sinks and we could just define a Java pojo that will be 
filled from the yaml file. That will make it easier for implementations to have 
different types in the configuration.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to