ivankelly commented on a change in pull request #1550: Issue #1517: make 
getLastConfirmedEntry in ManagedLedgerImpl return real LAC
URL: https://github.com/apache/incubator-pulsar/pull/1550#discussion_r180845490
 
 

 ##########
 File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -2222,7 +2222,19 @@ public int getPendingAddEntriesCount() {
 
     @Override
     public Position getLastConfirmedEntry() {
-        return lastConfirmedEntry;
+        PositionImpl lastMessagePosition = lastConfirmedEntry;
 
 Review comment:
   This could be done in initialize(), as once the last ledger has been loaded, 
you can set lastConfirmedEntry. lastConfirmedEntry only gets set with entry id 
as -1 in initializeBookKeeper() now. This could be removed if you do it in 
inititalize().
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to