merlimat commented on a change in pull request #1562: Converted to v2 topic 
names test related to ProducerConsumerBase
URL: https://github.com/apache/incubator-pulsar/pull/1562#discussion_r181184646
 
 

 ##########
 File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/v1/TopicLookup.java
 ##########
 @@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.lookup.v1;
+
+import io.swagger.annotations.ApiResponse;
+import io.swagger.annotations.ApiResponses;
+
+import javax.ws.rs.DefaultValue;
+import javax.ws.rs.Encoded;
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+import javax.ws.rs.Produces;
+import javax.ws.rs.QueryParam;
+import javax.ws.rs.container.AsyncResponse;
+import javax.ws.rs.container.Suspended;
+import javax.ws.rs.core.MediaType;
+
+import org.apache.pulsar.broker.lookup.TopicLookupBase;
+import org.apache.pulsar.broker.web.NoSwaggerDocumentation;
+import org.apache.pulsar.common.naming.TopicName;
+
+@Path("/v2/destination/")
 
 Review comment:
   It's probably worth a comment in the code, but it's correct. 
   
   The lookup API was already `/v2/` in Pulsar 1.xxx. This was internally 
versioned at Yahoo to not clash from earlier API. 
   
   Since we're adding now the "Pulsar v2" we cannot rename this topic lookup 
into `/v1`. Rather the difference here would be : 
`lookup/v2/destination/persistent/prop/cluster/ns/topic` vs 
`lookup/v2/topic/persistent/prop/ns/topic`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to