sijie commented on a change in pull request #1538: Add rate limit for client
lookup requests
URL: https://github.com/apache/incubator-pulsar/pull/1538#discussion_r181180624
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
##########
@@ -246,14 +246,24 @@ ClientBuilder authentication(String authPluginClassName,
Map<String, String> aut
ClientBuilder statsInterval(long statsInterval, TimeUnit unit);
/**
- * Number of concurrent lookup-requests allowed on each broker-connection
to prevent overload on broker.
+ * Number of concurrent lookup-requests allowed to send on each
broker-connection to prevent overload on broker.
* <i>(default: 5000)</i> It should be configured with higher value only
in case of it requires to produce/subscribe
* on thousands of topic using created {@link PulsarClient}
*
* @param maxConcurrentLookupRequests
*/
ClientBuilder maxConcurrentLookupRequests(int maxConcurrentLookupRequests);
+ /**
+ * Number of max lookup-requests allowed on each broker-connection to
prevent overload on broker.
+ * <i>(default: 20000)</i> It should not be smaller than
maxConcurrentLookupRequests.
+ * Requests that inside maxConcurrentLookupRequests already send to
broker, and requests beyond
+ * maxConcurrentLookupRequests and under maxLookupRequests will wait in
each client cnx.
+ *
+ * @param maxLookupRequests
Review comment:
I would encourage add `@since` annotation in the comment to indicate when
the method was introduce.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
