ivankelly commented on a change in pull request #1549: offloadPrefix 
implementation for managed ledger
URL: https://github.com/apache/incubator-pulsar/pull/1549#discussion_r181395155
 
 

 ##########
 File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 ##########
 @@ -1850,9 +1854,172 @@ public void offloadFailed(ManagedLedgerException e, 
Object ctx) {
 
     @Override
     public void asyncOffloadPrefix(Position pos, OffloadCallback callback, 
Object ctx) {
-        callback.offloadFailed(new ManagedLedgerException("Not implemented"), 
ctx);
+        PositionImpl requestOffloadTo = (PositionImpl)pos;
+        if (!isValidPosition(requestOffloadTo)) {
+            callback.offloadFailed(new InvalidCursorPositionException("Invalid 
position for offload"), ctx);
+            return;
+        }
+
+        Position firstUnoffloaded;
+
+        List<LedgerInfo> ledgersToOffload = Lists.newArrayList();
+        synchronized (this) {
+            log.info("[{}] Start ledgersOffload. ledgers={} totalSize={}", 
name, ledgers.keySet(),
+                     TOTAL_SIZE_UPDATER.get(this));
+
+            if (STATE_UPDATER.get(this) == State.Closed) {
+                log.info("[{}] Ignoring offload request since the managed 
ledger was already closed", name);
+                callback.offloadFailed(new ManagedLedgerAlreadyClosedException(
+                                               "Can't offload closed managed 
ledger"), ctx);
+                return;
+            }
+
+            long current = ledgers.lastKey();
+
+            // the first ledger which will not be offloaded. Defaults to 
current,
+            // in the case that the whole headmap is offloaded. Otherwise it 
will
+            // be set as we iterate through the headmap values
+            long firstLedgerRetained = current;
+            for (LedgerInfo ls : ledgers.headMap(current).values()) {
+                if (requestOffloadTo.getLedgerId() > ls.getLedgerId()) {
+                    if (!ls.hasOffloadContext()) {
+                        ledgersToOffload.add(ls);
+                    }
+                } else {
+                    firstLedgerRetained = ls.getLedgerId();
+                    break;
+                }
+            }
+            firstUnoffloaded = PositionImpl.get(firstLedgerRetained, 0);
+        }
+
+        if (ledgersToOffload.isEmpty()) {
+            callback.offloadComplete(firstUnoffloaded, ctx);
+            return;
+        }
+
+        log.info("[{}] Going to offload ledgers {}", name,
+                 ledgersToOffload.stream().map(l -> 
l.getLedgerId()).collect(Collectors.toList()));
+        List< Pair<Long, CompletableFuture<byte[]>> > contexts = 
ledgersToOffload.stream()
+            .map(info -> {
+                    long ledgerId = info.getLedgerId();
+                    Map<String, String> extraMetadata = 
ImmutableMap.of("ManagedLedgerName", name);
+                    CompletableFuture<byte[]> context = 
getLedgerHandle(ledgerId).thenCompose(
+                            readHandle -> 
config.getLedgerOffloader().offload(readHandle, extraMetadata));
+                    return Pair.of(ledgerId, context);
+                }).collect(Collectors.toList());
+
+        CompletableFuture.allOf(contexts.stream().map(p -> 
p.getRight()).toArray(CompletableFuture[]::new))
 
 Review comment:
   My line of thinking was to do it all together to reduce the number of 
metadata operations. It's likely there's only be one ledger offloaded at a time 
anyhow though, so will change it to sequential.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to