jerrypeng commented on a change in pull request #1636: Rename Connect
`Message` interface to `Record`
URL: https://github.com/apache/incubator-pulsar/pull/1636#discussion_r183587224
##########
File path:
pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java
##########
@@ -42,8 +42,8 @@
/**
* Attempt to publish a type safe collection of messages
*
- * @param message Object to publish to the sink
+ * @param outputValue output value
* @return Completable future fo async publish request
*/
- CompletableFuture<Void> write(final Message<T> message);
+ CompletableFuture<Void> write(T outputValue);
Review comment:
Shouldn't this be wrapped around the a Record object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
