ivankelly opened a new pull request #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637 This patch modifies the LedgerOffloader interface to allow the caller to first record that parameters used for an offload, and then confirm these parameters after offload has successfully completed. The first record of offload can then be used for cleanup if an error occurred or the node offloading crashed while the offload was in progress. The patch adds a new parameter, uid, or Unique Identifier, to all calls, and removes the concept of offload context. The ledger ID and uid should be enough information to find the offloaded object in longterm storage. When an offload is requested for a ledger, the managed ledger will generate a random unique identifier for the offload attempt. It will store this in the managed ledger metadata, before starting to copy data to the longterm storage. If there is a failure, or crash before the offload completes, the ledger ID and uid are used to cleanup the attempt. If the attempt is successful, a completed flag is set in the metadata. Master Issue: #1511
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
