merlimat opened a new pull request #1652: Refactored BrokerService to use 
Optional in topics map
URL: https://github.com/apache/incubator-pulsar/pull/1652
 
 
   ### Motivation
   
   The broker service is currently keeping a map of topics, whose value type is 
`CompletableFuture<Topic>`. There is some recurring code there to handle topics 
that are being loaded or that have recently failed to load and were not cleaned 
up yet.
   
   Also, after #1500 the topic instance returned by the future can be "null" if 
the topic was not being forced to create. 
   
   ### Modifications
   
   Refactored `BrokerService` to use `CompletableFuture<Optional<Topic>>` for 
the topics map value and consolidated all the future handling checks in a 
single method.
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to