merlimat closed pull request #1654: Enable dispatch-throttling for non backlog consumers by default. URL: https://github.com/apache/incubator-pulsar/pull/1654
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/conf/broker.conf b/conf/broker.conf index d38abf7046..2b0365c431 100644 --- a/conf/broker.conf +++ b/conf/broker.conf @@ -140,9 +140,9 @@ dispatchThrottlingRatePerTopicInMsg=0 # default message-byte dispatch-throttling dispatchThrottlingRatePerTopicInByte=0 -# Default dispatch-throttling is disabled for consumers which already caught-up with published messages and -# don't have backlog. This enables dispatch-throttling for non-backlog consumers as well. -dispatchThrottlingOnNonBacklogConsumerEnabled=false +# By default we enable dispatch-throttling for both caught up consumers as well as consumers who have +# backlog. +dispatchThrottlingOnNonBacklogConsumerEnabled=true # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic maxConcurrentLookupRequest=10000 diff --git a/conf/standalone.conf b/conf/standalone.conf index b593f00d6b..69662877fb 100644 --- a/conf/standalone.conf +++ b/conf/standalone.conf @@ -129,9 +129,9 @@ dispatchThrottlingRatePerTopicInMsg=0 # default message-byte dispatch-throttling dispatchThrottlingRatePerTopicInByte=0 -# Default dispatch-throttling is disabled for consumers which already caught-up with published messages and -# don't have backlog. This enables dispatch-throttling for non-backlog consumers as well. -dispatchThrottlingOnNonBacklogConsumerEnabled=false +# By default we enable dispatch-throttling for both caught up consumers as well as consumers who have +# backlog. +dispatchThrottlingOnNonBacklogConsumerEnabled=true # Max number of concurrent lookup request broker allows to throttle heavy incoming lookup traffic maxConcurrentLookupRequest=10000 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
