merlimat commented on a change in pull request #1553: Pulsar 2.0 docs
URL: https://github.com/apache/incubator-pulsar/pull/1553#discussion_r184608324
##########
File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md
##########
@@ -95,41 +95,39 @@ Client libraries can provide their own listener
implementations for consumers. T
### Topics
-As in other pub-sub systems, topics in Pulsar are named channels for
transmitting messages from producers to consumers. Topic names are URLs that
have a well-defined structure:
+As in other pub-sub systems, topics in Pulsar are named channels for
transmitting messages from {% popover producers %} to {% popover consumers %}.
Topic names are URLs that have a well-defined structure:
-{% include topic.html p="property" c="cluster" n="namespace" t="topic" %}
+{% include topic.html type="{persistent|non-persistent}" ten="tenant"
n="namespace" t="topic" %}
-| Topic name component | Description
|
-|:---------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| `persistent` | It identifies type of topic. Pulsar supports two kind
of topics: persistent and non-persistent. In persistent topic, all messages are
durably [persisted](#persistent-storage) on disk (that means on multiple disks
unless the {% popover broker %} is {% popover standalone %}), whereas
[non-persistent](#non-persistent-topics) topic does not persist message into
storage disk. |
-| `property` | The topic's {% popover tenant %} within the instance.
Tenants are essential to {% popover multi-tenancy %} in Pulsar and can be
spread across clusters.
|
-| `cluster` | Where the topic is located. Typically there will be
one {% popover cluster %} for each geographical region or data center.
|
-| `namespace` | The administrative unit of the topic, which acts as a
grouping mechanism for related topics. Most topic configuration is performed at
the [namespace](#namespace) level. Each property (tenant) can have multiple
namespaces. |
-| `topic` | The final part of the name. Topic names are freeform
and have no special meaning in a Pulsar instance.
|
+Topic name component | Description
+:--------------------|:-----------
+`persistent` / `non-persistent` | This identifies the type of topic. Pulsar
supports two kind of topics: [persistent](#persistent-storage) and
[non-persistent](#non-persistent-topics). In persistent topic, all messages are
durably [persisted](#persistent-storage) on disk (that means on multiple disks
unless the {% popover broker %} is {% popover standalone %}), whereas
[non-persistent](#non-persistent-topics) topic does not persist message into
storage disk.
Review comment:
We should clarify that `persistent` is the default. If you don't specify the
type, it will always be persistent:
`my-topic` --> `persistent://public/default/my-topic`
`my-tenant/my-ns/my-topic` --> `persistent://my-tenant/my-ns/my-topic`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
