jai1 closed pull request #1713: Fix: deadlock while closing non-persistent topic URL: https://github.com/apache/incubator-pulsar/pull/1713
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java index 44a9e14434..5d6b4baf66 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java @@ -462,8 +462,12 @@ void removeSubscription(String subscriptionName) { FutureUtil.waitForAll(futures).thenRun(() -> { log.info("[{}] Topic closed", topic); - brokerService.pulsar().getExecutor().submit(() -> brokerService.removeTopicFromCache(topic)); - closeFuture.complete(null); + // unload topic iterates over topics map and removing from the map with the same thread creates deadlock. + // so, execute it in different thread + brokerService.executor().execute(() -> { + brokerService.removeTopicFromCache(topic); + closeFuture.complete(null); + }); }).exceptionally(exception -> { log.error("[{}] Error closing topic", topic, exception); isFenced = false; ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services