ivankelly commented on a change in pull request #1678: PIP-17: provide BlockAwareSegmentInputStream implementation and test URL: https://github.com/apache/incubator-pulsar/pull/1678#discussion_r185435514
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSegmentInputStream.java ########## @@ -0,0 +1,219 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker.s3offload.impl; + +import static com.google.common.base.Preconditions.checkState; + +import com.google.common.collect.Lists; +import com.google.common.primitives.Ints; +import io.netty.buffer.ByteBuf; +import io.netty.buffer.CompositeByteBuf; +import io.netty.buffer.PooledByteBufAllocator; +import java.io.IOException; +import java.io.InputStream; +import java.util.Iterator; +import java.util.List; +import java.util.concurrent.ExecutionException; +import org.apache.bookkeeper.client.api.LedgerEntries; +import org.apache.bookkeeper.client.api.LedgerEntry; +import org.apache.bookkeeper.client.api.ReadHandle; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * + * The BlockAwareSegmentInputStream for each cold storage data block. + * It contains a byte buffer, which contains all the content for this data block. + * DataBlockHeader + entries(each with format[[entry_size -- int][entry_id -- long][entry_data]]) + * + */ +public class BlockAwareSegmentInputStream extends InputStream { + private static final Logger log = LoggerFactory.getLogger(BlockAwareSegmentInputStream.class); + + private static final byte[] blockEndPadding = Ints.toByteArray(0xFEDCDEAD); + + private final ReadHandle ledger; + private final long startEntryId; + private final int blockSize; + + // Number of Message entries that read from ledger and been readout from this InputStream. + private int blockEntryCount; + // Number of payload Bytes read from ledger, and has been has been kept in this InputStream. + private int payloadBytesHave; + // Number of bytes that has been kept in this InputStream. + private int blockBytesHave; + + // tracking read status for both header and entries. + // Bytes that already been read from this InputStream + private int bytesReadOffset = 0; + // Byte from this index is all padding byte + private int dataBlockFullOffset; + private final InputStream dataBlockHeaderStream; + + // how many entries want to read from ReadHandle each time. + private static final int entriesNumberEachRead = 100; + // buf the entry size and entry id. + private static final int entryHeaderSize = 4 /* entry size*/ + 8 /* entry id */; + // Keep a list of all entries ByteBuf, each element contains 2 buf: entry header and entry content. + private List<CompositeByteBuf> entriesByteBuf = null; Review comment: It can be a List<ByteBuf>. The user of the buffer doesn't need to know what's backing it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
