ivankelly commented on a change in pull request #1784: PIP-17: impl
deleteOffloaded() for S3ManagedLedgerOffloader
URL: https://github.com/apache/incubator-pulsar/pull/1784#discussion_r188593231
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
##########
@@ -196,8 +196,21 @@ static String indexBlockOffloadKey(ReadHandle readHandle,
UUID uuid) {
@Override
public CompletableFuture<Void> deleteOffloaded(long ledgerId, UUID uid) {
+
CompletableFuture<Void> promise = new CompletableFuture<>();
- promise.completeExceptionally(new UnsupportedOperationException());
+
+ scheduler.submit(() -> {
+ try {
+ s3client.deleteObject(bucket, dataBlockOffloadKey(ledgerId,
uid));
Review comment:
use deleteObjects(), so that it's only one call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
