massakam commented on a change in pull request #1795: Fix C++ MurmurHash3
algorithm
URL: https://github.com/apache/incubator-pulsar/pull/1795#discussion_r188864565
##########
File path: pulsar-client-cpp/tests/HashTest.cc
##########
@@ -58,10 +58,18 @@ TEST(HashTest, testJavaStringHash) {
TEST(HashTest, testMurmur3_32Hash) {
Murmur3_32Hash hash;
+ std::string k1 = "k1";
+ std::string k2 = "k2";
std::string key1 = "key1";
std::string key2 = "key2";
+ std::string key01 = "key01";
+ std::string key02 = "key02";
// Same value as Java client
+ ASSERT_EQ(2110152746, hash.makeHash(k1));
+ ASSERT_EQ(1479966664, hash.makeHash(k2));
Review comment:
That's because this problem occurs when the key length is not a multiple of
4.
We need to test if the hashes generated from keys whose length is not a
multiple of 4 are correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
