merlimat commented on a change in pull request #1812: Used protobuf-3.x and auto-generation for ManagedLedger and schema registry protobuf URL: https://github.com/apache/incubator-pulsar/pull/1812#discussion_r189378991
########## File path: pulsar-broker/src/main/proto/SchemaRegistryFormat.proto ########## @@ -20,7 +20,7 @@ syntax = "proto2"; package pulsar.schema; option java_package = "org.apache.pulsar.broker.service.schema.proto"; -option optimize_for = LITE_RUNTIME; +option optimize_for = SPEED; Review comment: Change here was because `LITE_RUNTIME` generated code from protobuf-3x was having compile errors. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
