jai1 closed pull request #1817: Fixed mem leak when acknowledging while
disconnected from broker
URL: https://github.com/apache/incubator-pulsar/pull/1817
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
index b74bb139ef..4629aca545 100644
---
a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
+++
b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
@@ -479,13 +479,13 @@ public boolean isBatchingAckTrackerEmpty() {
private CompletableFuture<Void> sendAcknowledge(MessageId messageId,
AckType ackType,
Map<String,Long>
properties) {
MessageIdImpl msgId = (MessageIdImpl) messageId;
- final ByteBuf cmd = Commands.newAck(consumerId, msgId.getLedgerId(),
msgId.getEntryId(),
- ackType, null, properties);
// There's no actual response from ack messages
final CompletableFuture<Void> ackFuture = new
CompletableFuture<Void>();
if (isConnected()) {
+ final ByteBuf cmd = Commands.newAck(consumerId,
msgId.getLedgerId(), msgId.getEntryId(),
+ ackType, null, properties);
cnx().ctx().writeAndFlush(cmd).addListener(new
GenericFutureListener<Future<Void>>() {
@Override
public void operationComplete(Future<Void> future) throws
Exception {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
