sijie commented on a change in pull request #1831: Don't set Pulsar Memory if
variable is already set
URL: https://github.com/apache/incubator-pulsar/pull/1831#discussion_r190008560
##########
File path: conf/pulsar_tools_env.sh
##########
@@ -42,7 +42,9 @@
# PULSAR_GLOBAL_ZK_CONF=
# Extra options to be passed to the jvm
-PULSAR_MEM=" -Xmx256m -XX:MaxDirectMemorySize=256m"
+if [ -z "$PULSAR_MEM" ]; then
+ PULSAR_MEM=" -Xmx256m -XX:MaxDirectMemorySize=256m"
Review comment:
ah i see
you can probably simplify this with
```
PULSAR_MEM=${PULSAR_MEM:-"-Xmx256m -XX:MaxDirectMemorySize=256m"}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
