jai1 commented on a change in pull request #1821: Closing client when
Proxyconnection is disconnected
URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r190063721
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java
##########
@@ -140,6 +140,10 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
directProxyHandler.outboundChannel.close();
}
+ if (client != null) {
+ client.close();
+ }
Review comment:
We changed the logic to have one client per ProxyConnection
https://github.com/apache/incubator-pulsar/pull/1707
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
