srkukarni commented on a change in pull request #1833: adding worker to 
instance health check
URL: https://github.com/apache/incubator-pulsar/pull/1833#discussion_r190090206
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto
 ##########
 @@ -65,7 +65,12 @@ message MetricsData {
     map<string, DataDigest> metrics = 1;
 }
 
+message HealthCheckResult {
 
 Review comment:
   I believe that we periodically already do getFunctionStatus? Do we want to 
overload that function instead of adding a new one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to