ivankelly commented on a change in pull request #1841: Fix flaky test with s3
backend
URL: https://github.com/apache/incubator-pulsar/pull/1841#discussion_r190538519
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOffloader.java
##########
@@ -191,8 +195,12 @@ static String indexBlockOffloadKey(long ledgerId, UUID
uuid) {
metadata));
promise.complete(null);
} catch (Throwable t) {
+ try {
+ s3client.deleteObject(bucket, dataBlockKey);
+ } catch (Throwable throwable) {
Review comment:
Similarly, report the bucket and key which delete failed on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
