mgodave commented on a change in pull request #1845: Functions schema 
integration
URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r191500284
 
 

 ##########
 File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java
 ##########
 @@ -94,6 +94,11 @@
      */
     ConsumerBuilder<T> topics(List<String> topicNames);
 
+    /**
+     *
+     */
+    ConsumerBuilder<T> addTopic(String topicName, Schema<T> schema);
 
 Review comment:
   YES! This is very confusing. Basically, I'm trying to solve a disconnect 
between functions and the multi-subscribe feature. Multi-subscribe assumes that 
everything has a single schema (this may be a flawed assumption) and functions 
allows you to add a SerDe per input topic, which, in my opinion, is the more 
logical approach (we just want them all to resolve to the same input type for 
the function no matter what the data is stored as). So, this was my attempt as 
solving that. I'm happy to see if there are any other ways around this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to